Changeset 5f50c28

Timestamp:

12/09/11 10:19:22 (5 months ago)

Author:

mrook

Branches:

master

Children:

bec429e

Parents:

e9c90e3

git-author:

Michiel Rook <mrook@…> (12/09/11 10:19:22)

git-committer:

Michiel Rook <mrook@…> (12/09/11 10:19:22)

Message:

Refs #782 - use Phar::buildFromIterator() to massively speed up phar generation

File:

• classes/phing/tasks/ext/phar/PharPackageTask.php (modified) (1 diff)

classes/phing/tasks/ext/phar/PharPackageTask.php

@@ -207 +207 @@
 
             foreach ($this->filesets as $fileset) {
-                foreach ($fileset as $realFileName) {
-                    /*
-                     * Calculate local file name.
-                     */
-                    $localFileName = $realFileName;
-                    if (0 === strpos($realFileName, $baseDirectory)) {
-                        $localFileName = substr(
-                            $realFileName,
-                            strlen($baseDirectory)
-                        );
-                    }
-
-                    $this->log(
-                        'Adding '.$realFileName.' as '.$localFileName.' to package',
-                        Project::MSG_VERBOSE
-                    );
-
-                    $phar->addFile($realFileName, $localFileName);
-                }
+                $this->log(
+                    'Adding specified files in ' . $fileset->getDir($this->project) . ' to package',
+                    Project::MSG_VERBOSE
+                );
+                
+                $phar->buildFromIterator($fileset, $baseDirectory);
             }