Ticket #103 (reopened defect)

Opened 2 years ago

Last modified 8 months ago

coverage-report task breaks non-ascii UTF-8 characters in PHP files

Reported by: junyaogura+phing@gmail.com Assigned to: hans
Priority: major Milestone:
Component: phing-tasks-ext Version: 2.3.0beta1
Keywords: Cc:

Description

CoverageReportTask::highlightSourceFile() uses utf8_encode() to convert encoding but utf8_encode() is not considers non-ascii characters, thus generated coverage report html contains unreadable characters.

I'd suggest using mb_convert_encoding() when mbstring module available. Like this: 

                if (function_exists('mb_convert_encoding')) {
                    $lines[$i] = mb_convert_encoding($line, 'UTF-8');
                } else {
                    $lines[$i] = utf8_encode($line);
                }

This change is very helpful for multibyte users.

Attachments

Change History

05/06/07 10:05:20 changed by mrook

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in r187, thanks!

05/21/08 09:26:00 changed by anonymous

  • status changed from closed to reopened.
  • resolution deleted.

Szia Balẳ!

El��r is szeretn鮫 megk��nni, hogy pr󢡬sz Neknk seg�ni! Nekem 2 gyem van, az egyik aut󮫡t ellopt᫦nbsp; 鳦nbsp; a biztos� ᬴al elutalt ��eg ennyivel kevesebb volt a Merkantil Bank szerint. Ennek a szerz�� sz᭡: CPLM/500279 70.514,- forint.

A mᳩk szerz��n鬠visszaadtuk az aut󴠩s ennyi ��eg maradt tartozᳫ鮴. Szerz�� sz᭺ CPLM00/504444 956.386,- forint.

Sajnos mind a k鴠gy b�s᧯n van mᲮ Nem tudom, hogy � is megoldhat󠥠a dolog.

M駥gyszer k��.

Ildik󦮢sp; Peti

Add/Change #103 (coverage-report task breaks non-ascii UTF-8 characters in PHP files)