stripphpcomments currupts some .png files while using copy?

[bonebreaker@…]

I had a copy task working on a fileset with stripphpcomments in the filterchain.

Some .png files were corrupted in the process, I removed the filterchain from the copy task and now it all works fine. Only some .png files were corrupted (< 10%) I attached one of the .png that got corrupted by Phing so that you can try to reproduce.

[bonebreaker@…]

.png file corrupted by stripphpcomments

[hans]

The correct way to deal with this is to make sure that *.png files are not included in the copy.

For example:

<!-- first copy everything except PHP files -->
<copy todir="${destdir}">
   <fileset dir="${srcdir}">
     <include name="**"/>
     <exclude name="**/*.php"/>
   </fileset>
</copy>

<!-- now copy only the PHP files and use a filterchain -->
<copy todir="${destdir}">
   <fileset dir="${srcdir}">
     <include name="**/*.php"/>
   </fileset>
   <filterchain>
     <stripphpcomments/>
   </filterchain>
</copy>