Modify

Ticket #138 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

dbdeploy task definition

Reported by: luke.crouch@… Owned by: hans
Priority: major Milestone:
Component: phing-tasks-ext Version: 2.2.0
Keywords: Cc:

Description

I just finished writing a dbdeploy task definition for phing (like the similar one for Ant) and thought it would make a good contribution to the phing project. how do I go about submitting it for inclusion?

Attachments

Change History

comment:1 Changed 4 years ago by hans

Hi -- thanks for your contribution offer!

There are several options here. You can 1) write to me (hans (at) xmpl.org) off-list to request an SVN account and commit the changes yourself or 2) attach a unified diff to this ticket and one of us will apply it to the source. Either way, we ask that you also take a few minutes to add some documentation to the appropriate place (Appendix) in the XHTML documentation too. As we've seen, undocumented tasks tend not to get any use!

Thanks! Hans

comment:2 Changed 4 years ago by luke.crouch@…

so how do I add the documentation? and can I checkout from svn anonymously to easily create the diff via svn diff?

thanks.

comment:3 Changed 4 years ago by hans

yes, you can check out anonymously (from trunk, please) and create the diff against that. As for documentation, just edit the AppendixC-OptionalTasks.html file ( http://phing.info/trac/browser/trunk/docs/phing_guide/book/chapters/appendixes/AppendixC-OptionalTasks.html for reference) and submit that as part of the unified diff.

Again, I'm also happy to create an SVN account for you, if that'd be simpler. (Just send me an off-list email w/ your desired username.)

comment:4 Changed 4 years ago by luke.crouch@…

I sent you an email to hans at xmpl dot org. I'm working on polishing up the code and adding documentation to the appendix.

thanks.

comment:5 Changed 4 years ago by lcrouch

so now how can I pick up and close tickets related to the dbdeploy task? this one can be closed, but then I'd also like to assign the bug to myself as well.

comment:6 Changed 4 years ago by hans

Sorry -- there was a missing permission. You should now have ability to edit, delete, etc.

comment:7 Changed 4 years ago by lcrouch

  • Status changed from new to closed
  • Resolution set to fixed
View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.