PhingCallTask should call setHaltOnFailure

[Oz Solomon]

Problem: <phingcall> silently eats up all failures.

Technical Description: <phingcall> is implemented by PhingCallTask which in turn uses PhingTask. The problem is that PhingTask defaults to haltonerror=false. This is not the expected behavior when calling a task within the same build file.

The solution is to add the line in bold to PhingCallTask.php:

function init() {

$this->callee = $this->project->createTask("phing"); $this->callee->setOwningTarget($this->getOwningTarget()); $this->callee->setTaskName($this->getTaskName()); $this->callee->setHaltOnFailure(true); add this

$this->callee->init();

}

[hans]

Good suggestion, yes. This is fixed in r299 (and r300 in trunk)