Undefined variable in PhingTask.php

[Oz Solomon]

Line 162 of PhingTask.php is

$buildFailed = false;

That line needs to move to the beginning of the processFile() function (line 201).

As it currently stands, when you reach this line at the end of processFile()

if ($this->haltOnFailure && $buildFailed) {

If there was no exception, then $buildFailed is undefined.

[hans]

Wow .. thank you again, yes. This is fixed in r303 (and r304, trunk).

P.S. Do you want an SVN account to help fix these issues as you find them? Please send a note to the dev list if you would like an account.