Modify

Ticket #201 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

Improve Phing's ability to work as an "embedded" process

Reported by: hans Owned by: hans
Priority: major Milestone: 2.3.1
Component: phing-core Version: 2.3.0
Keywords: Cc:

Description (last modified by hans) (diff)

Currently Phing does some things that make it impossible to invoke it within other applications. For example:

  1. Phing currently calls exit() in its shutdown() method.
  2. The phing.php script does a bit more setup/teardown than it should.
  3. Exceptions are being printed to STDERR by Phing class currently instead of bubbling up to calling phing.php script.
  4. Resource paths are only resolved relative to include_path, which shouldn't have to include the phing.home dir.
  5. INI settings that Phing changes are not restored in shutdown phase.
  6. Trailing spaces may prevent inclusion in web apps ("output already started") errors

Attachments

Change History

comment:1 Changed 4 years ago by hans

  • Description modified (diff)

comment:2 Changed 4 years ago by hans

(In [322]) Refs #201 - (IN PROGRESS!) Checking in in-progress work to improve Phing's ability to be embedded in other applications. ERROR HANDLING HAS NOT BEEN FULLY TESTED WITH THIS CHANGESET.

comment:3 Changed 4 years ago by hans

(In [323]) Refs #201 - Added improved support for arg parsing in Phing::execute() as well as better error handling between phing.php CLI script and Phing class.

comment:4 Changed 4 years ago by hans

  • Description modified (diff)

comment:5 Changed 4 years ago by hans

  • Description modified (diff)

comment:6 Changed 4 years ago by hans

  • Status changed from new to assigned
  • Description modified (diff)

comment:7 Changed 4 years ago by hans

(In [325]) Refs #201 - Removed closing ?> from class files.

comment:8 Changed 4 years ago by hans

(In [326]) Refs #201 - Fixing argument parsing from bug introduced in [323]

comment:9 Changed 4 years ago by hans

(In [327]) Refs #201 - Fixing another (!) argument parsing bug introduced in [326]

comment:10 Changed 4 years ago by hans

(In [327]) Refs #201 - Fixing another (!) argument parsing bug introduced in [326]

comment:11 Changed 4 years ago by hans

(In [330]) Refs #201 - Fixing support for additional properties

comment:12 Changed 4 years ago by hans

(In [330]) Refs #201 - Fixing support for additional properties

comment:13 Changed 4 years ago by hans

(In [331]) Refs #201 - Changing Phing::start() API to accept array of properties instead of Properties object.

comment:14 Changed 4 years ago by hans

  • Status changed from assigned to closed
  • Resolution set to fixed

Am closing. As of r331, this system is working very well embedded within other PHP scripts. The fact that all errors bubble through as exceptions and no exit() is performed by Phing class, is a definite improvement.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.