Ticket #268 (assigned enhancement)

Opened 5 months ago

Last modified 3 months ago

Patch - xmlproperties Task

Reported by: jbondc@openmv.com Assigned to: hans (accepted)
Priority: major Milestone: 2.4.0
Component: phing-tasks-system Version: 2.3.1RC1
Keywords: Cc:

Description

Hi,

I have migrated our ant build system to phing since it seems to have matured quite a bit!

The first major issue was no xmlproperties as a core task: http://ant.apache.org/manual/CoreTasks/xmlproperty.html

Attached is a patch (tested on windows - no semanticAttributes). I made some other 'fixes' along the way, through I've only had a quick look through the code.

i.e. The TarTask.php and ZipTask.php both extend FileSet and copy getFiles(), but it seems like it should belong in FileSet (very useful - many use cases).

I needed this for a complicated task that calls FileSet.

After applying patch:

xmlproperty=phing.tasks.system.XmlPropertyTask

Enjoy! Happying phinging

Attachments

xmlproperties.zip (4.4 kB) - added by jbondc on 08/20/08 14:31:44.

Change History

08/20/08 14:31:44 changed by jbondc

  • attachment xmlproperties.zip added.

10/16/08 00:37:50 changed by hans

  • status changed from new to assigned.
  • milestone changed from 2.3.1 to 2.4.0.

Thanks for this patch! -- I'm going to move this to 2.4, since it adds functionality. Also (and I haven't looked into the zip yet), some docs would be helpful -- as a diff against the checked-in xhtml docs, would be great.

Add/Change #268 (Patch - xmlproperties Task)