Modify ↓

Ticket #287 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

DateSelector.php bug

Reported by: ian.maffett@… Owned by: hans
Priority: major Milestone: 2.3.1
Component: phing-core Version: 2.3.1RC1
Keywords: Cc:

Description

There's a bug in the DateSelector.php file at line 207, isSelected function

return (($file->lastModified() . $this->granularity) > $this->seconds);

Should be

return (($file->lastModified() - $this->granularity) > $this->seconds);

Attachments

Change History

comment:1 Changed 3 years ago by hans

(In [396]) Refs #287 - Fixing typo in date comparison code.

comment:2 Changed 3 years ago by hans

(In [397]) Refs #287 - Fixing typo in date comparison code.

comment:3 Changed 3 years ago by hans

  • Status changed from new to closed
  • Resolution set to fixed

Thanks, Ian -- fixed in r396 (2.3) and r397 (2.4). Will be part of soon-to-be-released 2.3.1 release.

View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.