FtpDeployTask is not setting passive mode, which makes uploading files impossible in some environments

[[mi.olszewski] [et] [gmail[.com]]

Phing version: 2.3.3

In my environment FtpDeployTask was unable to upload files onto FTP server until I've added call to Net_FTP::setPassive(). As it is stated in ftp_pasv PHP documention: "In passive mode, data connections are initiated by the client, rather than by the server. It may be needed if the client is behind firewall." and currently most of computers are behind some firewall...

Thus I've modified FtpDeployTask to accept additional parameter (passive). If set to true task calls Net_FTP::setPassive() after successful login (as stated in ftp_pasv documentation).

Attached, version of FtpDeployTask with passive attribute plus minor modifications:

• call to Net_FTP::disconnect() before throwing BuildException
• $this->dir is always created, just in case that it doesn't exist

Please re-integrate at least 'passive' attribute into phing FtpDeployTask. Thanks

[mi.olszewski@…]

improved version of FtpDeployTask

[mrook]

This bug has been fixed in the SVN tree, revision r437.

Thank you for the report, and for helping us make Phing better!