PHPUnit2Util::getDefinedClasses

[elias@…]

PHPUnit2Util::getDefinedClasses issues a notice:

[PHP Error] Undefined index: ... [line 111 of /usr/share/pear/phing/tasks/ext/phpunit2/PHPUnit2Util.php]

Line 111 should be replaced with:

$declaredClasses = array_merge(get_declared_interfaces(), get_declared_classes());

[mrook]

I agree with your bugreport, but not with your proposed solution. The method getDefinedClasses() does not (and should not) care about interfaces.

A better solution (one which I would commit) would be:

if (is_array(self::$definedClasses[$filename]))
{
  return self::$definedClasses[$filename];
}
else
{
  return array();
}

[mrook]

The "is_array" in the previous comment should obviously be "isset".

[elias]

i din't thougt much about the context, i just wanted the error go away. :) your solution is fine too.

[mrook]

Fixed in r68, thanks!