dbdeploy task does not comply with dbdeploy guidelines

[Jean-Marc Fontaine]

The dbdeploy task makes the undo section mandatory while dbdeploy documentation says "You can optionally add an undo section to your script."

Moreover the undo tag is not correct in the dbdeploy task. It looks for "– @UNDO" while dbdeploy indicates "–@UNDO" should be used.

See  http://code.google.com/p/dbdeploy/wiki/GuidelinesForUsingDbdeploy.

[mrook]

What are you suggesting exactly? That dbdeploy should not write the undo part to undoOutputFile (defaults to 'dbdeploy_undo.sql') unless the attribute is explicitly set?

The "-@UNDO" issue was reported in #397 and fixed in r636.

[tomasz]

I confirm this bug. DbDeployTask is NOT WORKING when delta script is missing @UNDO section. Whole contents of delta script is added to undooutputfile, when missing this section!

Guildlines says:

8. You can optionally add an undo section to your script. [...]

[mrook]

@tomasz: which version of Phing are you using?

[tomasz]

2.4.1