Modify

Ticket #430 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

FtpDeployTask is extremely un-verbose...

Reported by: FaZend <team@…> Owned by: mrook
Priority: minor Milestone: 2.4.1
Component: phing-core Version: 2.4.0
Keywords: Cc:

Description

FtpDeployTask provides almost no log after its operation. It's impossible to understand what is the problem.

Besides that it depends on Net_FTP package, which is not supported. Maybe it would be good to implement FTP uploader inside Phing more effectively?

 http://code.google.com/p/fazend/source/browse/trunk/FaZend/Application/Phing/UploadByFTP.php

This is the example of such a task, which we are using for the last 10 months. We're ready to migrate it to PHING and support it there. What do you think?

Attachments

Change History

comment:1 Changed 2 years ago by mrook

We can add logging to FtpDeployTask - Net_FTP might not be maintained but there are no bugs reported.

comment:2 Changed 2 years ago by FaZend <team@…>

Fair enough. Thus, would be perfect to have verbose option in FtpDeployTask, which will turn ON the logging of the following events:

  • connected to server
  • logged in
  • change of directory
  • upload success/failure/no-need

Thanks

comment:3 Changed 2 years ago by mrook

  • Priority changed from major to minor
  • Status changed from new to assigned

Ok!

comment:4 Changed 2 years ago by mrook

(In [730]) Refs #430 - add additional logging statements

comment:5 Changed 2 years ago by mrook

Please review the changes in r730, let me know if this is what you need (logging statements should show when you use the '-verbose' startup parameter).

comment:6 Changed 2 years ago by FaZend <team@…>

yes, looks good. would be nice to have log messages for every file uploaded and deleted on the server (if any).

also, I would add more details to the Connected to server message. Let's say what is the name of the server, port number, login name. It's very useful when you're using this task for the first time and are not sure that you configured it properly in build.xml. The richer the log, the better. Thanks.

comment:7 Changed 2 years ago by mrook

(In [735]) Refs #430 - add server info to logging

comment:8 Changed 2 years ago by mrook

  • Status changed from assigned to closed
  • Resolution set to fixed

The code already logged individual file transfers, see line 202. Additional info was added in r735.

comment:9 follow-up: ↓ 10 Changed 2 years ago by FaZend <team@…>

looks like FtpDeployTask re-sends all files by FTP, without validation of existing file structure on the server. if it is the case, it is a performance problem. sometimes there are thousands of files and directories (if Zend Framework is used for example) and full upload of all of them - it's 30-40 minutes. while incremental upload will take 3-5 minutes.

comment:10 in reply to: ↑ 9 Changed 2 years ago by mrook

Replying to FaZend <team@…>:

looks like FtpDeployTask re-sends all files by FTP, without validation of existing file structure on the server. if it is the case, it is a performance problem. sometimes there are thousands of files and directories (if Zend Framework is used for example) and full upload of all of them - it's 30-40 minutes. while incremental upload will take 3-5 minutes.

Next time please open a new ticket for new issues, see #462.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.