Modify

Ticket #449 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

ZipTask creates ZIP file but doesn't set file/dir attributes

Reported by: fabria@… Owned by: mrook
Priority: minor Milestone: 2.4.1
Component: phing-tasks-ext Version: 2.4.0
Keywords: Cc:

Description

Hi to all, sorry to bother if it has already been asked (spent most of the morning searching for this...). If i create a ZipTask the ZIP file creates perfectly, but its content is not readable. I shot some screenshots and upload a ZIP file (Joomla module extension) to show that

  • file ("A" or no attrib) and dir ("D") attributes are not set
  • file upload to Joomla install system fails as it is unable to parse it.

Screenshots:

The directories in the basedir are not empty, in case anyone wonders. They contain files and other directories.

Here's the code I used to run the task:

<property name="build.zipdeployfile" value="${build.builddir}/${phing.project.name}_devel_${build.version}_${DSTAMP}.zip" />

<fileset dir="${project.basedir}" id="zipfiles">

<include name="/" /> <exclude name="build.xml" /> <exclude name=".buildpath" /> <exclude name=".project" /> <exclude name=".settings/" /> <exclude name=".externalToolBuilders/" />

</fileset>

<zip destfile="${build.zipdeployfile}">

<fileset refid="zipfiles" />

</zip>

PHP 5.3.1 (XAMPP), Phing 2.4.0 running on a Windows 7 HP 64 bit notebook.

I really don't know where else to look. Thanks for any help and please advise if more information is needed.

Attachments

mod_simplecalendar_countdown_devel_0.3.1b_20100220.zip Download (18.5 KB) - added by fabria@… 2 years ago.
ZipTask created File
after.zip Download (19.7 KB) - added by fabria@… 2 years ago.
manually created file (with 7-zip)

Change History

Changed 2 years ago by fabria@…

ZipTask created File

Changed 2 years ago by fabria@…

manually created file (with 7-zip)

comment:1 Changed 2 years ago by fabria@…

Addition to my post: if I use TarTask, the file (gzip) is created correctly and the Joomla installer is able to parse it without problem. I'll stick to Tar for the moment.

comment:2 Changed 2 years ago by mrook

Could you please confirm this bug still exist with current sources (from trunk)? A change was made to the ZipTask in r736.

comment:3 Changed 2 years ago by fabria@…

Hi thanks for the fast reply. I will checkout as soon as possible and report here.

comment:4 Changed 2 years ago by mrook

  • Status changed from new to assigned

comment:5 Changed 2 years ago by mrook

(In [743]) Refs #449 - explicitly add all directories to zip file

comment:6 Changed 2 years ago by mrook

Please test the proposed fix in r743.

comment:7 Changed 2 years ago by mrook

  • Status changed from assigned to closed
  • Resolution set to fixed

Marking this fixed - please reopen if you continue to experience problems.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.