Modify ↓

Ticket #456 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

Fileset's dir should honor expandsymboliclinks

Reported by: ashnazg@… Owned by: mrook
Priority: minor Milestone: 2.4.1
Component: phing-core Version: 2.4.0
Keywords: Cc:

Description

The dir checking logic in AbstractFileSet::getDirectoryScanner does not allow the dir's value to itself be a symlink... presumably expandsymboliclinks only currently applies to the contents inside the dir, rather than the dir itself.

This patch ignores the isDirectory() check if the dir value is a symlink AND the expandsymboliclinks is TRUE.

An improvement to this patch might be some additional checking to be done when dir is found to be a symlink.

Attachments

AbstractFileSet.php.patch Download (819 bytes) - added by ashnazg@… 2 years ago.
wrap the isDir check with an isLink check

Change History

Changed 2 years ago by ashnazg@…

wrap the isDir check with an isLink check

comment:1 Changed 2 years ago by mrook

(In [744]) Refs #456 - Fileset's dir should honor expandsymboliclinks (patch by Chuck Burgess)

comment:2 Changed 2 years ago by mrook

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from 2.4.2 to 2.4.1

Patch applied in r744 - thanks!

View ↑

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.