Modify

Ticket #460 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

FtpDeployTask error

Reported by: FaZend <team@…> Owned by: mrook
Priority: major Milestone: 2.4.1
Component: phing-core Version: 2.4.0
Keywords: Cc:

Description

I think that it should be fixed

 Non-static method PEAR::isError() should not be called statically,
assuming $this from incompatible context,
in /usr/local/PEAR/phing/tasks/ext/FtpDeployTask.php [line:135]

Attachments

Change History

comment:1 Changed 2 years ago by mrook

I can wrap every PEAR::isError() line in with '@', would that work?

comment:2 follow-up: ↓ 4 Changed 2 years ago by FaZend <team@…>

let's try… if you can't call it through $this.

comment:3 Changed 2 years ago by FaZend <team@…>

btw, this is what I see at the end of phing report:

/usr/local/bin/phing: line 22: 13641 Segmentation fault      $PHP_COMMAND -d
html_errors=off -qC /usr/local/PEAR/phing.php
-logger phing.listener.AnsiColorLogger "$@"

Without FtpUploadTask everything works fine.

Maybe this isError() defect is causing such failure?

comment:4 in reply to: ↑ 2 Changed 2 years ago by mrook

Replying to FaZend <team@…>:

let's try… if you can't call it through $this.

Well, no -- $this refers to the task. isError() should be called statically, but since PEAR is PHP4 compatible, it can't explicitly define it as such.

comment:5 Changed 2 years ago by mrook

  • Status changed from new to assigned
  • Milestone changed from 2.4.2 to 2.4.1

comment:6 Changed 2 years ago by mrook

(In [748]) Refs #460 - suppress E_STRICT errors when calling isError()

comment:7 Changed 2 years ago by mrook

  • Status changed from assigned to closed
  • Resolution set to fixed

We believe this issue has been fixed in the SVN trunk.

Thank you for the report, and for helping us make Phing better!

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.