pearpkg2: newlines in notes removed

[cweiske@…]

When using newlines in a property for the release notes in pearpkg2 task, they are removed in the resulting package.xml:

  <property name="releasenotes" value="- Many SQL optimizations
- SemanticScuttle shows bookmarks 4 times faster now
- New config option to skip 'SET NAMES UTF8' call: $dbneedssetnames
- Do not highlight admin bookmarks when $enableAdminColors is disabled
- Add russian translation
- Make HTML export follow the specifications a bit better
- Fix bug #2953732: faulty error message for duplicate bookmarks
- Fix bug #2960663: do not send content-type headers twice for ajax/api scripts
- Fix bug #2976593: fr_FR locale is vietnamese
" />
...
    <option name="notes" value="${releasenotes}" />

Result:

 <notes>
- Many SQL optimizations - SemanticScuttle shows bookmarks 4 times faster now - New config option to skip &apos;SET NAMES UTF8&apos; call: $dbneedssetnames -
 Do not highlight admin bookmarks when $enableAdminColors is disabled - Add russian translation - Make HTML export follow the specifications a bit better - F
ix bug #2953732: faulty error message for duplicate bookmarks - Fix bug #2960663: do not send content-type headers twice for ajax/api scripts - Fix bug #2976
593: fr_FR locale is vietnamese
 </notes>

[victor]

The issue is actually not with pearpkg2 task, but with PropertyTask. For temporary workaround use following form:

<property name="releasenotes">
- Many SQL optimizations
- SemanticScuttle shows bookmarks 4 times faster now
- New config option to skip 'SET NAMES UTF8' call: $dbneedssetnames
- Do not highlight admin bookmarks when $enableAdminColors is disabled
- Add russian translation
- Make HTML export follow the specifications a bit better
- Fix bug #2953732: faulty error message for duplicate bookmarks
- Fix bug #2960663: do not send content-type headers twice for ajax/api scripts
- Fix bug #2976593: fr_FR locale is vietnamese
</property>

That would preserve EOLs and thus give the expected results.

I will have to check the W3C specs regarding EOLs in attribute values, and if they are ok, will look why they got stripped, in PropertyTask.

[victor]

As suspected, the whole thing is  Attribute-Value Normalization and has nothing to do with Phing tasks (I actually reviewed PropertyTask, but more out of curiosity than necessity).

If briefly: since attribute values are normalized, EOLs (and tabs) are turned into spaces, so above-mentioned work-around is actually the only conventional way to preserve your text as is (I will also advise to mark whole block as CDATA to have less worries with entities).

[cweiske@…]

Thanks for finding out.