Phing Doesn't Fail When PhpDoc Task Fails

[ashnazg@…]

Phing does not fail when a Phpdoc child task itself fails, and I can't tell from the manual that there is any way to tell Phing to fail when the PhpDoc task fails.

I've tested this several ways:

• put bad values in phpdoc's args, to force an "ERROR" message from phpdoc itself;
• kill the php process while phpdoc was running;
• phpdoc threw an malloc() failure due to low memory;

In all cases, Phing just keeps going like the phpdoc task finished successfully. I even put two phpdoc tasks in the same phing target, thinking perhaps the target would fail after the first phpdoc task failed, but no, it went right on to the second phpdoc task.

Shouldn't it be reporting a build failure when the phpdoc task failed, or is this an enhancement that needs to be added to Phing? Or, worse, is Phing already supposed to fail but Phpdoc is returning a success exit code even when it itself fails?

[mrook]

The Phing task *should* fail (throw a BuildExcepion) when phpdoc returns a non-zero exit code.

Additionally, any lines containing "ERROR" should be posted to the Phing error log (but do not necessarily trigger a BuildException).

[ashnazg@…]

Given that one of the last files written by a successful PhpDoc run is the "errors.html" file, I'm working around this issue like this:

<phpdoc destdir="docs" sourcepath="." output="HTML:Smarty:HandS" /> <available file="docs/errors.html" property="doc_completed" value="true" /> <fail unless="devdoc_completed" message="It APPEARS that the Doc generation failed." />

[anonymous]

Gallery model nude teen Art dc gallery washington

[hans]

I'm actually going to move this ahead in the hopes that newer versions of phpdoc will provide more potential for interop. Currently we are calling the phpdoc API directly and it is a completely atrocious API. One can only hope that they rectify this in future versions.

[ashnazg@…]

Thanks for the update.

I actually came onboard as one of the PhpDocumentor maintainers this year, and I'm hoping to keep Phing's needs in mind as I refactor things towards an improved v2.0. I have this bookmarked ( http://phing.tigris.org/servlets/ReadMsg?listName=dev&msgNo=441) to use as some level of guidance in my planning.

So, any specific things that phing would like to see can be directed to me. I can open any needed request items at pear.php.net to record them if no one at phing has a PEAR account. I'm looking forward to making these two products work together well in the PHP Continuous Integration realm.