Semantical error in PhingFile::getParent()

[micha@…]

a semantical error in class PhingFile prevents method getParent() to return the parent of a directory or file if the parent is the root directory of the filesystem.

example:

  $file = new PhingFile( "/tmp" );
  $parent = $file->getParent(); // $parent is null instead of "/"

a patch that fixes this problem is attached to this ticket. the patch is created against current revision 147.

[micha@…]

Patch for PhingFile against revision 147

[norman@…]

Sorry micha, your patch is incorrect, isn't it?

You wrote

    if (($this->prefixLength > 0) && (strlen($this->path) > $this->prefixLength))) { 
    ...
    }

but shouldn't it be

    if (($this->prefixLength > 0) && (strlen($this->path) > $this->prefixLength)) { 
    ...
    }

or am I missunderstand something? (Please count the numbers of '(' and ')'.)

Yours

Norman

[micha@…]

you're right - sorry, my fault. fixed a semantical error and added a syntax error...

patched patch will be attached ;)

[mrook]

Fixed in r163.

[hans]

Milestone 2.2.1 deleted

[Frank]

BOFH Excuse #208:

Your mail is being routed through Germany ... and they're censoring us.  italia cialis  http://www.compraviagraitalia.com/it/item/generic_cialis.html  viagra prezzi  http://compraviagraitalia.com/index.html

 fioricet price

 http://headachetreatment.net/index.html  viagra generico sicuro  http://www.compraviagraitalia.com/it/item/generic_viagra.html

 tramadol free shipping

 http://relievepain.org/tramadol-news/index.php?entry=entry090118-104934