Modify

Opened 2 years ago

Closed 2 years ago

#860 closed defect (fixed)

SvnBaseTask: getRecursive

Reported by: daniel.degasperi@… Owned by: mrook
Priority: minor Milestone: 2.4.12
Component: phing-tasks-ext Version: 2.4.9
Keywords: Cc:

Description

The method getRecursive is a little bit confusing:

Returns the non-recursive switch

function getRecursive()
{
    return isset( $this->svnSwitches['non-recursive'] ) ? $this->svnSwitches['non-recursive'] : '';
}

The counterpart sets the non-recursive switch, doing a inversion on the value

function setRecursive($value)
{
    $this->svnSwitches['non-recursive'] = is_bool($value) ? !$value : TRUE;
}

Bug?

Attachments (0)

Change History (2)

comment:1 Changed 2 years ago by mrook

  • Milestone changed from TBD to 2.4.12
  • Priority changed from tbd to minor
  • Type changed from feedback to defect

comment:2 Changed 2 years ago by Michiel Rook

  • Resolution set to fixed
  • Status changed from new to closed

Fixes #860 - Also invert the boolean in getRecursive()

Changeset: fdc08b4757c5894270cac4ea97ed3e4eee4159ef

Add Comment

Modify Ticket

Action
as closed The owner will remain mrook.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.