Modify

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#324 closed enhancement (fixed)

Add a JavaScript minifier task

Reported by: mikey@… Owned by: mrook
Priority: major Milestone:
Component: phing-tasks-ext Version: 2.3.2
Keywords: Cc:

Description

I would like to see a JavaScript minifier task included in Phing. I volunteer to provide such a task based on the one I created for Stubbles, see http://stubbles.net/browser/framework/trunk/src/main/php/org/stubbles/phing/tasks/stubJsMinTask.php. Just tell me if you are interested, I will provide a patch then.

Attachments (1)

jsmin.patch (17.2 KB) - added by mikey@… 8 years ago.
Patch to include JsMinTask including bundled JsMin 1.1.1

Download all attachments as: .zip

Change History (7)

comment:2 Changed 8 years ago by mrook

  • Owner changed from hans to mrook

Patches are always welcome!

comment:2 Changed 8 years ago by mrook

(In [458]) Refs #324 - add JsMin task

comment:3 Changed 8 years ago by mrook

  • Resolution set to fixed
  • Status changed from new to closed

This bug has been fixed in the SVN tree, revision r458.

Thank you for the report, and for helping us make Phing better!

comment:4 Changed 8 years ago by mikey@…

You were quite a bit faster than I, however as my patch was nearly finished I completed and tested it anyway. It is against 2.3 and bundles JsMin so the user does not have to install it separately. (JsMin is under the MIT license, I'm not that deep into those license issues but I think it should go well with Phing's LGPL.)

If you keep your patch you should fix the class name, it is still stubJsMinTask, but in default.properties you reference it is JsMinTask.

Changed 8 years ago by mikey@…

Patch to include JsMinTask including bundled JsMin 1.1.1

comment:5 Changed 8 years ago by mrook

(In [466]) Refs #324 - apply full patch to JsMinTask

comment:6 Changed 8 years ago by mrook

(In [467]) Refs #324 - Include JsMin library and set svn:keywords

Add Comment

Modify Ticket

Action
as closed The owner will remain mrook.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.