Modify

Opened 7 years ago

Closed 6 years ago

#632 closed enhancement (fixed)

CoverageThresholdTask needs exclusion option/attribute

Reported by: FaZend <team@…> Owned by: bschultz
Priority: major Milestone: 2.4.6
Component: phing-core Version: 2.4.4
Keywords: Cc:

Description

We should be able to exclude certain classes from coverage threshold validation, for example:

<coverage-threshold database="${coverage.database}"
  perProject="70"
  perClass="0"
  perMethod="0">
  <excludes>
    <file>**/*IntegrationTest.php</file>
    <class>Model_Filter_Windows</class>
    <method>Model_System::execute()</method>
  </excludes>
</coverage-threshold>

It is just an example, but the functionality is very important. Thanks.

Attachments (0)

Change History (6)

comment:1 Changed 7 years ago by mrook

  • Milestone changed from TBD to 2.4.6

comment:2 Changed 7 years ago by mrook

How would this be different from excluding certain files when calling the coverage-setup task ?

comment:3 Changed 7 years ago by mrook

Reply from poster:

If I exclude them during coverage-setup than they won't be visible in coverage-report. The goal here is to disable coverage threshold validation for certain files/classes/methods, but still keep them visible in coverage reporting. Mostly because we need to see how to add more coverage.

comment:4 Changed 6 years ago by bschultz

  • Owner changed from mrook to bschultz
  • Status changed from new to assigned

comment:5 Changed 6 years ago by bschultz

(In [1206]) Refs #632 - implemented option to exclude files, classes and methods from threshold validation therefore added a new datatype "Excludes" minimal refactoring for CoverageThresholdTask

comment:6 Changed 6 years ago by bschultz

  • Resolution set to fixed
  • Status changed from assigned to closed

Add Comment

Modify Ticket

Action
as closed The owner will remain bschultz.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.