Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#958 closed defect (fixed)

Property wrapped in if/then structure is not substituted by it's value

Reported by: mail@… Owned by: mrook
Priority: major Milestone: 2.5.0
Component: phing-core Version: 2.4.14
Keywords: Cc:

Description

When wrapped in an if/then structure, my properties are passed in literal form instead of their value. I've run in to this problem when using this template: https://github.com/reload/phing-drupal-template but I've replicated it using a basic build file: http://pastebin.com/vs2x4pUd.

I've tested the basic file in different versions and in 2.4.12 it works as expected. From 2.4.13 up to 2.5-alpha it's broken.

I'm really new to Phing and unable to provide a patch, I'm sorry.

Attachments (0)

Change History (4)

comment:1 Changed 5 years ago by mrook

  • Priority changed from tbd to major

comment:2 Changed 5 years ago by mrook

Conditions are now wrapped in UnknownElement (to enable dynamic loading of custom conditions). Unfortunately, RuntimeConfigurable::maybeConfigure only calls ProjectConfigurator::addText once (on project init, when the property has not been set yet). This has been rectified.

(see #511 for reference)

comment:3 Changed 5 years ago by Michiel Rook

  • Resolution set to fixed
  • Status changed from new to closed

Fixes #958 - allow multiple calls to ProjectConfigurator:addText to allow reconfiguration of UnknownElement::addText

Changeset: 36e647208098fe00530564a6c41cd9224f23d199

comment:4 Changed 5 years ago by Michiel Rook

Fixes #958 - allow multiple calls to ProjectConfigurator:addText to allow reconfiguration of UnknownElement::addText

Changeset: 36e647208098fe00530564a6c41cd9224f23d199

Add Comment

Modify Ticket

Action
as closed The owner will remain mrook.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.